Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PythonSimulation constructor should abstract the parameters dict #115

Closed
braybaud opened this issue Jun 10, 2019 · 0 comments
Closed

PythonSimulation constructor should abstract the parameters dict #115

braybaud opened this issue Jun 10, 2019 · 0 comments
Labels
bug Something isn't working
Milestone
First prototype

Comments

@braybaud
Copy link

For example, currently this fails

sim = PythonSimulation({"a":1, "b":0})
sim.set_parameter("a", 10)

and only this works

sim = PythonSimulation({"parameters":{"a":1, "b":0}})
sim.set_parameter("a", 10)

We should make it more simple and handle both case in one.
@braybaud braybaud added the bug Something isn't working label Jun 10, 2019
@braybaud braybaud added this to the First prototype milestone Jun 10, 2019
@braybaud braybaud self-assigned this Jun 10, 2019
@braybaud braybaud mentioned this issue Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
First prototype
Development

No branches or pull requests
1 participant
@braybaud