Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #142 #154

Merged
merged 2 commits into from Jun 20, 2019
Merged

Fix #142 #154

merged 2 commits into from Jun 20, 2019

Conversation

braybaud
Copy link

The batching system should work as expected.
See idmtools_core/tests/test_regression.py for the test proving it.

@shchen-idmod
Copy link
Collaborator

shchen-idmod commented Jun 20, 2019

@braybaud Still not doing batch.
In COMPSPlatform.py: last line should be outside for loop

def create_simulations(self, simulation_batch):
        self._login()
        created_simulations = []

        for simulation in simulation_batch:
            s = Simulation(name=simulation.experiment.name, experiment_id=simulation.experiment.uid,
                           configuration=Configuration(asset_collection_id=simulation.experiment.assets.uid))

            self.send_assets_for_simulation(simulation, s)
            s.set_tags(simulation.tags)
            created_simulations.append(s)

            Simulation.save_all(None, save_semaphore=Simulation.get_save_semaphore())

@braybaud
Copy link
Author

@shchen-idmod, I see, the issue was actually more in the platform rather than the batching system. Thanks, the fix has been pushed.

@shchen-idmod
Copy link
Collaborator

Looks good

@shchen-idmod shchen-idmod merged commit e487272 into InstituteforDiseaseModeling:dev Jun 20, 2019
@braybaud braybaud deleted the Fix-142 branch June 20, 2019 23:26
@ZDu-IDM ZDu-IDM mentioned this pull request Nov 20, 2019
@devclinton devclinton added the Core label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants