Improve first run project setup #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests depend on vagrant and virtualbox, but they weren't specified in `script/setup` so you couldn't run the tests immediately after setup. This also fixes an error with the initial `bundle install`: ``` [master] instrumentald $ ./script/setup Fetching gem metadata from https://rubygems.org/....... Fetching version metadata from https://rubygems.org/.. Fetching dependency metadata from https://rubygems.org/. Resolving dependencies........ Your lockfile was created by an old Bundler that left some things out. You can fix this by adding the missing gems to your Gemfile, running bundle install, and then removing the gems from your Gemfile. The missing gems are: * CFPropertyList depended upon by facter * CFPropertyList depended upon by puppet … fatal: No live threads left. Deadlock? /Users/jason/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/bundler-1.14.2/lib/bundler/worker.rb:43:in `pop' /Users/jason/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/bundler-1.14.2/lib/bundler/worker.rb:43:in `deq’ … Unfortunately, an unexpected error occurred, and Bundler cannot continue. ``` Adding CFPropertyList to the gemfile fixes this. Contrary to the directions, then removing the gems doesn't work, so it stays for now.
|
👍 much smoother for future Nate. |
|
I had some verify failures with puppet, but, no more than I did previously... I'll investigate. |
|
(the things that are still broken are fixed in #65) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests depend on vagrant and virtualbox, but they weren't specified
in
script/setupso you couldn't run the tests immediately after setup.This also fixes an error with the initial
bundle install:Adding CFPropertyList to the gemfile fixes this. Contrary to the
directions, then removing the gems doesn't work, so it stays for now.