Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

Unbreak -DMFX_ENABLE_SW_FALLBACK=OFF #1846

Merged
merged 1 commit into from Dec 18, 2019
Merged

Unbreak -DMFX_ENABLE_SW_FALLBACK=OFF #1846

merged 1 commit into from Dec 18, 2019

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Dec 18, 2019

Fixes #1845

@jbeich
[build] Some directories are used by hardware encoder as well
9d26f17 
In file included from _studio/mfx_lib/encode/mjpeg/src/mfx_mjpeg_encode.cpp:29:
_studio/mfx_lib/encode/mjpeg/include/mfx_mjpeg_encode.h:32:10: fatal error: 'umc_mjpeg_video_encoder.h' file not found
 #include "umc_mjpeg_video_encoder.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
onabiull
onabiull approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@onabiull onabiull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@onabiull onabiull merged commit 8414944 into Intel-Media-SDK:master Dec 18, 2019
@dvrogozh
Copy link
Contributor

Per my understanding _studio/mfx_lib/encode contains SW only implementation. I think we need to exclude it entirely from the build with the -DMFX_ENABLE_SW_FALLBACK=OFF. I created #1855 to address that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@onabiull onabiull onabiull approved these changes

@dmitryermilov dmitryermilov Awaiting requested review from dmitryermilov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to build on 32-bit architecture
3 participants
@jbeich @dvrogozh @onabiull