This repository has been archived by the owner on May 17, 2023. It is now read-only.
samples: use WARNING_FLAGS definition #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olya-tsi
suggested changes
Jan 29, 2018
| @@ -17,7 +17,6 @@ include_directories ( | |||
| list( APPEND LIBS_VARIANT sample_common ) | |||
|
|
|||
| set(DEPENDENCIES ${skipping} itt libmfx dl pthread) | |||
| set( defs "-Werror" ) | |||
There was a problem hiding this comment.
Originally samples had separate build infrastructure and didn't use -Werror and didn't support WARNING_FLAGS. Now WARNING_FLAGS can be used, so better to make your change in order to your commit message, i.e. set WARNING_FLAGS in CMakeLists.txt for sample_hevc_fei.
There was a problem hiding this comment.
Ok. I was under the impressions that WARNING_FLAGS was handled at a higher/top level of the project configuration. I will double check.
uartie
force-pushed
the
samples-werror
branch
from
21700e4
to
47109a7
Compare
uartie
changed the title
|
@otsirule patch updated. |
onabiull
suggested changes
Jan 30, 2018
Don't hard-code -Werror into compiler flags. Instead, use the configured value from WARNING_FLAGS. This allows the user to disable -Werror if needed. Currently, on some compiler versions there are still some warnings being generated in samples/hevc_fei. So remove hard-coded -Werror and use WARNING_FLAGS instead. Fixes Intel-Media-SDK#48 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie
force-pushed
the
samples-werror
branch
from
47109a7
to
cf324a4
Compare
|
@onabiull patch updated |
onabiull
approved these changes
Jan 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't hard-code -Werror into compiler flags. Instead, use
the configured value from WARNING_FLAGS. This allows
the user to disable -Werror if needed.
Currently, on some compiler versions there are still
some warnings being generated in samples/hevc_fei. So
remove hard-coded -Werror and use WARNING_FLAGS instead.
Fixes #48