-
Notifications
You must be signed in to change notification settings - Fork 457
Conversation
@@ -17,7 +17,6 @@ include_directories ( | |||
list( APPEND LIBS_VARIANT sample_common ) | |||
|
|||
set(DEPENDENCIES ${skipping} itt libmfx dl pthread) | |||
set( defs "-Werror" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally samples had separate build infrastructure and didn't use -Werror and didn't support WARNING_FLAGS. Now WARNING_FLAGS can be used, so better to make your change in order to your commit message, i.e. set WARNING_FLAGS in CMakeLists.txt for sample_hevc_fei.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I was under the impressions that WARNING_FLAGS was handled at a higher/top level of the project configuration. I will double check.
21700e4
to
47109a7
Compare
@otsirule patch updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately samples code not yet warning-free. Could you please add this option to sample_hevc_fei only?
Don't hard-code -Werror into compiler flags. Instead, use the configured value from WARNING_FLAGS. This allows the user to disable -Werror if needed. Currently, on some compiler versions there are still some warnings being generated in samples/hevc_fei. So remove hard-coded -Werror and use WARNING_FLAGS instead. Fixes Intel-Media-SDK#48 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
47109a7
to
cf324a4
Compare
@onabiull patch updated |
Don't hard-code -Werror into compiler flags. Instead, use
the configured value from WARNING_FLAGS. This allows
the user to disable -Werror if needed.
Currently, on some compiler versions there are still
some warnings being generated in samples/hevc_fei. So
remove hard-coded -Werror and use WARNING_FLAGS instead.
Fixes #48