Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make input a dictionary for multi-modal object detection (#95)" #187

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

dxoigmn
Copy link
Contributor

@dxoigmn dxoigmn commented Jun 30, 2023

This reverts commit de77a9d.

What does this PR do?

We don't really have multi-modal training working, so revert this until we do. This makes main at least usable with our other work.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 馃檭

@dxoigmn dxoigmn requested a review from mzweilin June 30, 2023 23:25
@dxoigmn dxoigmn marked this pull request as ready for review June 30, 2023 23:26
@mzweilin
Copy link
Contributor

I released v0.5.1 that reverts the same PR: https://github.com/IntelLabs/MART/releases/tag/v0.5.1

@mzweilin
Copy link
Contributor

I would like to merge this PR into main, because Adversary can perform transforms internally in #203

It's better to keep the datamodule transforms simple and consistent with the Armory input format.

@dxoigmn
Copy link
Contributor Author

dxoigmn commented Jul 15, 2023

You can merge then :)

@mzweilin mzweilin merged commit 2cfc963 into main Jul 15, 2023
3 checks passed
@mzweilin mzweilin deleted the revert_de77a9d1363f4bbfc94f5301263323c4ce291956 branch July 15, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants