Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename src/dst Nodes For Point Cloud Featurization #228

Merged
merged 2 commits into from
May 29, 2024

Conversation

melo-gonzo
Copy link
Collaborator

Would close the issue raised in #132 and #227. Renames the src_nodes and dst_nodes that are used for point cloud featurization to pc_src_nodes and pc_dst_nodes.

@laserkelvin
Copy link
Collaborator

I'm trying to grasp the connection between renaming the variables and how it addresses #132 and #227. Could you explain how the renaming impacts this?

@laserkelvin laserkelvin added bug Something isn't working data Issues related to data loading, pipelining, etc. labels May 29, 2024
@melo-gonzo
Copy link
Collaborator Author

@laserkelvin src_nodes and dst_nodes are added to the overall data sample in the dataset classes. these same src_nodes and dst_nodes are pulled out when constructing the graph, for example in the dgl conversion . your own comment here may clear it up for you.

@laserkelvin
Copy link
Collaborator

Pre-commit hooks are failing on test_dataset, can you address them?

@laserkelvin laserkelvin merged commit e4bf2de into IntelLabs:main May 29, 2024
3 checks passed
@melo-gonzo melo-gonzo deleted the pc-node-choice-update branch June 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data Issues related to data loading, pipelining, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants