-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variables, references to members, late-initialization #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results235 tests 221 ✅ 27m 29s ⏱️ Results for commit 18474ce. ♻️ This comment has been updated with latest results. |
fmirus
requested changes
Jul 2, 2024
fmirus
reviewed
Jul 3, 2024
fmirus
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the final parameters of actions were generated during parsing.
To be able to support additional use cases, it is required to resolve just before execution.
With this PR the parsing is moved to a newly defined
execute()
method that is called with the actual execution of the behavior.One use case is, that an action might change variables values for later usage. This is now possible by internally creating a py-trees blackboard variable for any
VariableDeclaration
.Additionally it is now supported to refer to members of parameters (that can either be fixed parameters or variables). Example: