Moveit humble #88
Draft
Moveit humble #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results236 tests 222 ✅ 33m 25s ⏱️ Results for commit f5f8193. ♻️ This comment has been updated with latest results. |
Scenario Results8 tests 8 ✅ 14m 10s ⏱️ Results for commit 5440da5. ♻️ This comment has been updated with latest results. |
fmirus
requested changes
Jun 4, 2024
scenario_execution_ros/scenario_execution_ros/actions/move_to_joint_pose.py
Outdated
Show resolved
Hide resolved
simulation/gazebo/arm_sim_scenario/launch/sim_moveit_scenario_launch.py
Outdated
Show resolved
Hide resolved
simulation/gazebo/arm_sim_scenario/launch/sim_moveit_scenario_launch.py
Outdated
Show resolved
Hide resolved
| self.moveit2.planner_id = "RRTConnectkConfigDefault" | ||
|
|
||
| # Scale down velocity and acceleration of joints (percentage of maximum) | ||
| self.moveit2.max_velocity = 0.5 |
There was a problem hiding this comment.
for now ok, but this should become a parameter of the action
| callback_group=ReentrantCallbackGroup() | ||
| ) | ||
|
|
||
| self.moveit2.planner_id = "RRTConnectkConfigDefault" |
There was a problem hiding this comment.
for now ok, but this should become a parameter of the action
fmirus
requested changes
Jun 17, 2024
scenario_execution_moveit/scenario_execution_moveit/actions/move_to_joint_pose.py
Outdated
Show resolved
Hide resolved
scenario_execution_moveit/scenario_execution_moveit/actions/move_to_pose.py
Outdated
Show resolved
Hide resolved
scenario_execution_moveit/scenario_execution_moveit/actions/move_gripper.py
Outdated
Show resolved
Hide resolved
scenario_execution_moveit/scenario_execution_moveit/actions/move_to_joint_pose.py
Outdated
Show resolved
Hide resolved
scenario_execution_moveit/scenario_execution_moveit/actions/move_to_pose.py
Outdated
Show resolved
Hide resolved
fmirus
requested changes
Jul 3, 2024
|
|
||
| scenario example_moveit: | ||
| wx200: robotic_arm with: | ||
| keep(it.namespace == 'wx200') |
There was a problem hiding this comment.
could you please update this to the "modern" syntax, i.e., remove keep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moveit2 lib for scenario execution to control robotics manipulator
Pull request checklist
make check) pass locallyPull request type
Current behavior
No moveit2 support to control manipulators
New behavior
moveit2 support
How to test
First Install dependencies.
second:
third run: