Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and extract title sequence in make install #42

Merged

Conversation

janisozaur
Copy link
Collaborator

No description provided.

@janisozaur
Copy link
Collaborator Author

https://travis-ci.org/janisozaur/OpenRCT2/jobs/185019287 says it should be correct, but I'd like someone to check it.

@Gymnasiast
Copy link
Collaborator

michael@Marcus-Aurelius:~/Programma's/Code/CLionProjects/OpenRCT2/build$ make install
[100%] Built target openrct2
Install the project...
-- Install configuration: "RELEASE"
[100%] Built target openrct2
Scanning dependencies of target g2
[100%] Generating g2.dat
usage: sprite build <spritefile> <resourcedir> [silent]
[100%] Built target g2
CMake Error at cmake_install.cmake:40 (file):
  file DOWNLOAD error: cannot create directory
  '/usr/local/share/openrct2/title' - Specify file by full path name and
  verify that you have directory creation and file write privileges.


Makefile:115: recept voor doel 'install' is mislukt
make: *** [install] Fout 1

@janisozaur
Copy link
Collaborator Author

Well, you don't have permissions to install it there. Why would you install it there, though, and not specify a package prefix?

@Gymnasiast
Copy link
Collaborator

Er, I never do make install anyway. I just copy the executable and run it.

@janisozaur
Copy link
Collaborator Author

Yes, that's the preferred way for me too, but in yuor snippet you show that make install fails gracefully with a message about missing permission, and not tested the newly added functionality. If you want to install it system-wide obtain required permissions or alternatively install it to a package prefix or build target package, but that depends more on your system.

Travis-made package looks correct to me, you can obtain from the link i posted.

@IntelOrca IntelOrca merged commit d197383 into IntelOrca:use-external-title-sequences Dec 19, 2016
Gymnasiast pushed a commit that referenced this pull request Mar 30, 2024
nl-NL: Fix/amend some descriptions by @Gymnasiast in #42
    Update French translation by @rmnvgr in #43
    Normalize the ragtime tunes by @karst in #44
    Complete list of Fairground organ style 2 tunes by @karst in #45
    Update Hungarian translation by @anon569 in #47
    Add Mystic style by @SkyshardMelody in #46
    pt-BR: Translate Mystic Style by @tupaschoal in #48
    hu-HU: Translate Mystic Style by @anon569 in #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants