Disable vectorized bitwise_invert for boolean inputs
#1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overload would cause sufficiently large boolean arrays to produce unexpected results when cast to another type
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_359 ran successfully. |
ndgrigorian
changed the title
bitwise_invert on sufficiently large boolean inputsbitwise_invert boolean inputs
oleksandr-pavlyk
approved these changes
May 16, 2024
There was a problem hiding this comment.
This looks good to me. Thank you @ndgrigorian ! I have added @npolina4 as a reviewer as original reporter of this issue.
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_360 ran successfully. |
npolina4
approved these changes
May 16, 2024
ndgrigorian
changed the title
bitwise_invert boolean inputsbitwise_invert for boolean inputs
oleksandr-pavlyk
added a commit
that referenced
this pull request
May 16, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes removing the
sycl::vecoverload ofbitwise_invertfor boolean inputs to fix unexpected behaviors.Vectorized
bitwise_inverton boolean inputs would corrupt the data in a subtle way. When casting this data to an integer data type, 255 would always be the result of castingtrue.This is likely related to
operator!onsycl::vecreturning -1 fortrueand expecting the output type to be a signed integer type.