Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin compiler and MKL within range for 0.15 release #1849

Merged
merged 2 commits into from
May 23, 2024
Merged

Pin compiler and MKL within range for 0.15 release #1849

merged 2 commits into from
May 23, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 23, 2024 •
edited
Loading

This change pins compile-time version of the compiler to 2024.2.0, host MKL version to 2024.2.0, and restricts the range of compiler runtime and MKL libraries accordingly for dpnp=0.15.0.
Note, dpctl version will be pinned to 0.17.0 once it is available.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy. Looks good

@antonwolfy antonwolfy merged commit 12553df into maintenance/0.15.x May 23, 2024
26 of 47 checks passed
@antonwolfy antonwolfy deleted the pin-compiler-mkl-within-range-for-0.15-release branch May 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana

@ekomarova ekomarova Awaiting requested review from ekomarova

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonwolfy @vlad-perevezentsev