Implement syevd_batch/heevd_batch via syevd/heevd call #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/1867/index.html |
vlad-perevezentsev
force-pushed
the
impl_syevd_batch_via_syevd
branch
from
0a3d67b
to
671bb2c
Compare
vlad-perevezentsev
changed the title
vtavana
reviewed
Jun 6, 2024
antonwolfy
reviewed
Jun 6, 2024
| @@ -230,6 +230,136 @@ std::pair<sycl::event, sycl::event> | |||
| return std::make_pair(args_ev, syevd_ev); | |||
| } | |||
|
|
|||
| std::pair<sycl::event, sycl::event> | |||
| syevd_batch(sycl::queue &exec_q, | |||
There was a problem hiding this comment.
heevd_batch and syevd_batch looks exactly the same, isn't they?
The only sensible difference is array of callbacks, but it can be passed as an input argument.
There was a problem hiding this comment.
Yes, another difference is that we use ...dispatch_table and ...dispatch_vector to get a pointer to the executing function
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding
syevd_batchandheevd_batchimplementation as a separate function and provide iteration of the batch array within it to avoid allocation of each 2D array before callingsyevdandheevdto improve performance and avoid serialization of all host tasks in the queue in MKL call;Performance of
dpnp.eighon Iris Xe