implement dpnp.fft.fft and dpnp.fft.ifft using pybind11 extension
#1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jun 17, 2024
mkl_dft::domain is added to descriptor template for future impelemntation of REAL domain
antonwolfy
reviewed
Jul 3, 2024
antonwolfy
reviewed
Jul 8, 2024
antonwolfy
reviewed
Jul 9, 2024
antonwolfy
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
I don't have more comments, Thank you @vtavana, it was a lot of work done to add FFT extension to dpnp. It's great!
github-actions bot
added a commit
that referenced
this pull request
Jul 13, 2024
…#1879) * implement fft and ifft using pybind11 extension * fixing minor issues * address comments * link to dpnp doc for FFT background info * add TODO * update backend structure * update CMakefile * update tests * add out keyword and fix an issue with negative stride * fix sphinx spelling issues * update for mkl-2024.2 * implement in-place fft * update to reuse dpctl function * fix an issue for out keyword given as usm_ndarray * fix a test * add TODO * extend descriptor template mkl_dft::domain is added to descriptor template for future impelemntation of REAL domain * add incorrectly removed header * address comments * fix empty array test * implement async memory * address comments * use dpnp_array * update a test * fix pre-commit * consistency with stock NumPy for coverage report --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 100094a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
dpnp.fft.fftanddpnp.fft.ifftare implemented using pybind11 extension to call OneMKL DFT routines.