Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

[BUG] tests folder should be omitted for coverage run #98

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

anmyachev
Copy link
Contributor

No description provided.

@shssf
Copy link
Contributor

shssf commented Jul 24, 2019

Did you mean "should not be"?

@anmyachev
Copy link
Contributor Author

Did you mean "should not be"?

I mean that the hpat/tests folder should not be taken into account when calculating the test coverage. That is, must be specifically omitted for coverage run command (for example: 'coverage run --source ./hpat --omit ./hpat/tests/*')

@fschlimb
Copy link
Contributor

why?

@anmyachev
Copy link
Contributor Author

@fschlimb code coverage metric must show the percentage of the program source code that was executed during the testing process. Unless you explicitly exclude the testing folder, then this metric will be affected by code changes in the tests themselves.

For example, you can look at #97 , in which the coverage metric is reduced simply because I replaced a few lines in tests. It's false positive.

@fschlimb
Copy link
Contributor

I guess it's a matter of what you want to see. Coverage of the test-code is also an interesting metric.

@anmyachev
Copy link
Contributor Author

@shssf @fschlimb "Travis CI - Branch Expected — Waiting for status to be reported" it looks like a bug.
Maybe this will help? https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154

@shssf
Copy link
Contributor

shssf commented Jul 24, 2019

@anmyachev I see this issue in every PR in this repository

@anmyachev
Copy link
Contributor Author

@shssf @fschlimb FYI.
This fix can most likely be made only by the owner and should not take more than 10 minutes I think.

@anmyachev
Copy link
Contributor Author

@shssf can the PR be merged?

@shssf
Copy link
Contributor

shssf commented Jul 26, 2019

@fschlimb Yes, I think yes.

@fschlimb fschlimb merged commit 95a7bc4 into IntelPython:master Jul 26, 2019
kozlov-alexey pushed a commit to kozlov-alexey/sdc that referenced this pull request Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants