-
Notifications
You must be signed in to change notification settings - Fork 62
[BUG] tests folder should be omitted for coverage run #98
Conversation
Did you mean "should not be"? |
I mean that the |
why? |
@fschlimb code coverage metric must show the percentage of the program source code that was executed during the testing process. Unless you explicitly exclude the testing folder, then this metric will be affected by code changes in the tests themselves. For example, you can look at #97 , in which the coverage metric is reduced simply because I replaced a few lines in tests. It's false positive. |
I guess it's a matter of what you want to see. Coverage of the test-code is also an interesting metric. |
@shssf @fschlimb "Travis CI - Branch Expected — Waiting for status to be reported" it looks like a bug. |
@anmyachev I see this issue in every PR in this repository |
@shssf can the PR be merged? |
@fschlimb Yes, I think yes. |
No description provided.