Code style change part 2 #107

shssf · 2019-08-02T14:36:27Z

The result produced by python setup.py style -a command only.

fschlimb

In some cases a review was not possible on github because it go confused. Should not be an issue.

Is it possible to fix the one-line-or-{} issue with config-knobs?

fschlimb · 2019-08-02T14:40:35Z

generate_data/stock_data_read.py

@@ -11,7 +12,7 @@ def main():
    for symbol in stocks.Symbol:
        try:
            df = data.DataReader(symbol, 'google', start='1/1/2000')
-        except:
+        except BaseException:


autopep8 inserts this automatically?

Yes, I was also surprised. First time you seen this in setup.py exception handling in one of the previous PR.

fschlimb · 2019-08-02T14:41:08Z

hpat/_cv.cpp

+    PyObject_SetAttrString(m, "cv_mat_release", PyLong_FromVoidPtr((void*)(&cv_mat_release)));
+    PyObject_SetAttrString(m, "cv_delete_buf", PyLong_FromVoidPtr((void*)(&cv_delete_buf)));
+    PyObject_SetAttrString(m, "cv_resize", PyLong_FromVoidPtr((void*)(&cv_resize)));
+    PyObject_SetAttrString(m, "cv_imdecode", PyLong_FromVoidPtr((void*)(&cv_imdecode)));


fschlimb · 2019-08-02T14:45:47Z

hpat/_dict_ext.cpp

-            } else return 0;
+            }
+            else
+                return 0;


👎
same line or {}. This is no good.

Yes, these things needs to be addressed manually. I don't know automatic tool which inserts brackets in such case (around return 0;)

fschlimb · 2019-08-02T14:46:03Z

hpat/_dict_ext.cpp

-            if(n == 0) return 0;
-            const argument_type::value_type * ptr = x.data();
+            if (n == 0)
+                return 0;


fschlimb · 2019-08-02T14:46:36Z

hpat/_dict_ext.cpp

            // This is our fall-back, probably pretty slow
-            if((h = hashit(reinterpret_cast<const uint8_t *>(ptr), n)) != 0) return h;
+            if ((h = hashit(reinterpret_cast<const uint8_t*>(ptr), n)) != 0)
+                return h;


oh, this is everywhere. can this be fixed?

fschlimb · 2019-08-02T14:52:27Z

hpat/_hpat_sort.h

+    {
+        do
+            ++i;
+        while (comp_arr[i] <= pivot && i <= high);


again, this is no good. it should be on 1 line or using {}

hpat/ros.py

fschlimb · 2019-08-02T14:58:26Z

hpat/shuffle_utils.py

+                          'tmp_offset, send_buff_tup, out_arr_tup, send_counts_char_tup, '
+                          'recv_counts_char_tup, send_arr_lens_tup, send_arr_chars_tup, '
+                          'send_disp_char_tup, recv_disp_char_tup, tmp_offset_char_tup, '
+                          'send_arr_chars_arr_tup'))


fschlimb · 2019-08-02T14:59:55Z

hpat/shuffle_utils.py

+        tmp_offset_chars,
+        str_comma,
+        send_arr_chars_arrs,
+        str_comma)


This is a bit weird. the first arg to format should be right after the '(' and the rest aligned with that.
I think pep8 allows both, though.

I agree. I don't know what confused pycodestyle here. Original variant is worse in any case.

fschlimb · 2019-08-02T15:01:50Z

hpat/stringlib/asciilib.h

-#define STRINGLIB_TOSTR          PyObject_Str
-#define STRINGLIB_TOASCII        PyObject_ASCII
+#define STRINGLIB_TOSTR PyObject_Str
+#define STRINGLIB_TOASCII PyObject_ASCII


I also seen this and don't know what is better :-)

shssf · 2019-08-02T19:30:32Z

@fschlimb I think I addressed most of the comments. If something still exists we could address it later.

….TestDataFrame.test_sort_parallel test

…ataframe.TestDataFrame.test_sort_parallel test" This reverts commit a9b1614.

….TestDataFrame.test_sort_parallel test

dmitrii-zagornyi · 2019-08-05T15:21:52Z

hpat/__init__.py

@@ -1,8 +1,9 @@
+from ._version import get_versions


Imports should be grouped in the following order:

Standard library imports.

Related third party imports.

Local application/library specific imports.

You should put a blank line between each group of imports.

dmitrii-zagornyi · 2019-08-05T15:26:53Z

hpat/_datetime_ext.h

+                                                  npy_datetime* out) __UNUSED__;
+
+    static void*
+        np_datetime_date_array_from_packed_ints(uint64_t* dt_data, int64_t n_elems, PyObject* dt_date_class) __UNUSED__;


May be split parameters like in function above?

it fits into 120 symbols. That is why automatic code styler didn't change it

I'm also like to see return type of the function on the same line as function name. It quite helpful if you grep sources. But auto codestyler has this intermediate style. If you know how to deprecate this please add this comment into PR #108

* code_style_change_part_2

This reverts commit 9076493.

* Remove spark dependency (#102) Remove spark dependency from HPA; use pre-generated sdf_dt.pq * explicitly adding data-file (#104) * HPAT Build: Code style check for C and Python sources (#103) * HPAT Build: Code style check for C and Python sources * PR103. Comments partially addressed * Code style change part 1 (#106) * Style check config fo pystyle (#105) * Fix for pandas.merge wrong overload handling of 'on' args (#99) Problem description: merge_overload and merge_asof_overload functions use 'on' argument value to compute 'left_on' and 'right_on' arguments in a way that breaks type stability, causing compilation failure when 'on' is assigned a StringLiteral value. Error: File "../hpat/hiframes/dataframe_pass.py", line 202, in _run_assign return self._run_call(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 522, in _run_call return self._run_call_join(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 1488, in _run_call_join left_on = self._get_const_or_list(left_on_var) File "../hpat/hiframes/dataframe_pass.py", line 2135, in _get_const_or_list raise ValueError(err_msg) ValueError: Failed in hpat mode pipeline (step: typed dataframe pass) None Following tests should be fixed with this commit: test_join_cat1 (hpat.tests.test_join.TestJoin) test_join_cat2 (hpat.tests.test_join.TestJoin) test_join_cat_parallel1 (hpat.tests.test_join.TestJoin) test_join_datetime_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq2 (hpat.tests.test_join.TestJoin) test_join_outer_seq1 (hpat.tests.test_join.TestJoin) test_join_right_seq1 (hpat.tests.test_join.TestJoin) test_merge_asof_seq1 (hpat.tests.test_join.TestJoin) * [STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (#97) * pep8 style for 'test_strings.py'; flake8 check successful * pep8 style for 'test_utils.py' * pep8 style for 'test_series.py'; more readable * fixed 'test_string_series' * removed extra white spaces * deleted mention of flake8 * trigger build * Code style change part 2 (#107) * code_style_change_part_2 * Add more check in style configuration (#108) * code_style_part_3 (#109) * Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (#92) * Code style change part 4 (#110) * Revert "Code style change part 4 (#110)" This reverts commit dfc54ee. * Revert "Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (#92)" This reverts commit 231a76c. * Revert "code_style_part_3 (#109)" This reverts commit 4070ce3. * Revert "Add more check in style configuration (#108)" This reverts commit abf5bd0. * Revert "Code style change part 2 (#107)" This reverts commit 9076493. * Revert "[STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (#97)" This reverts commit 8641f7a. * Revert "Fix for pandas.merge wrong overload handling of 'on' args (#99)" This reverts commit a2a8ee5. * Revert "Style check config fo pystyle (#105)" This reverts commit 551c0e3. * Revert "Code style change part 1 (#106)" This reverts commit 6dae0b3. * Revert "HPAT Build: Code style check for C and Python sources (#103)" This reverts commit 1a30e4f. * Revert "explicitly adding data-file (#104)" This reverts commit 34a2260. * Revert "Remove spark dependency (#102)" This reverts commit 9e77fde. * Unskip passing dataframe tests Actually, following tests in test_dataframe.py are pass and can be unskipped: test_create1 test_len1 test_column_getitem1 test_df_apply test_df_apply_branch test_df_describe test_count1 test_append1 At the same time, test_sort_parallel and test_sort_parallel_single_col has some problems with __pycache__: - They are passed if execute the suite with -B - They are passed if execute them separate - They and failed when some tests above are unskipped. So, decide to skip them.

* Remove spark dependency (#102) Remove spark dependency from HPA; use pre-generated sdf_dt.pq * explicitly adding data-file (#104) * HPAT Build: Code style check for C and Python sources (#103) * HPAT Build: Code style check for C and Python sources * PR103. Comments partially addressed * Code style change part 1 (#106) * Style check config fo pystyle (#105) * Fix for pandas.merge wrong overload handling of 'on' args (#99) Problem description: merge_overload and merge_asof_overload functions use 'on' argument value to compute 'left_on' and 'right_on' arguments in a way that breaks type stability, causing compilation failure when 'on' is assigned a StringLiteral value. Error: File "../hpat/hiframes/dataframe_pass.py", line 202, in _run_assign return self._run_call(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 522, in _run_call return self._run_call_join(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 1488, in _run_call_join left_on = self._get_const_or_list(left_on_var) File "../hpat/hiframes/dataframe_pass.py", line 2135, in _get_const_or_list raise ValueError(err_msg) ValueError: Failed in hpat mode pipeline (step: typed dataframe pass) None Following tests should be fixed with this commit: test_join_cat1 (hpat.tests.test_join.TestJoin) test_join_cat2 (hpat.tests.test_join.TestJoin) test_join_cat_parallel1 (hpat.tests.test_join.TestJoin) test_join_datetime_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq2 (hpat.tests.test_join.TestJoin) test_join_outer_seq1 (hpat.tests.test_join.TestJoin) test_join_right_seq1 (hpat.tests.test_join.TestJoin) test_merge_asof_seq1 (hpat.tests.test_join.TestJoin) * [STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (#97) * pep8 style for 'test_strings.py'; flake8 check successful * pep8 style for 'test_utils.py' * pep8 style for 'test_series.py'; more readable * fixed 'test_string_series' * removed extra white spaces * deleted mention of flake8 * trigger build * Code style change part 2 (#107) * code_style_change_part_2 * Add more check in style configuration (#108) * code_style_part_3 (#109) * Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (#92) * Code style change part 4 (#110) * Cahnge tests execution Actually test suite should be executed via hpat.runtests: python -u -m hpat.runtests -v This resolve the issue with doulbe test suite execution which occurs due to the "python -u -m unittest -v" command import all files in tree including runtests.py and runtests.py triggers 1-st suite execution. Then unittest triggers 2-d. Add decorator to execute some tests (mostly parallel) 2 or more times (depending on existance of REPEAT_TEST_NUMBER environment variable) This should highlight issues like the test fails if executed twice because is corrupts memory during first execution (like test_series_head_index_parallel1) Skip test_series_head_index_parallel1 because it triggers memory corruption. This should be fixed. * Revert "Code style change part 4 (#110)" This reverts commit dfc54ee. * Revert "Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (#92)" This reverts commit 231a76c. * Revert "code_style_part_3 (#109)" This reverts commit 4070ce3. * Revert "Add more check in style configuration (#108)" This reverts commit abf5bd0. * Revert "Code style change part 2 (#107)" This reverts commit 9076493. * Revert "[STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (#97)" This reverts commit 8641f7a. * Revert "Fix for pandas.merge wrong overload handling of 'on' args (#99)" This reverts commit a2a8ee5. * Revert "Style check config fo pystyle (#105)" This reverts commit 551c0e3. * Revert "Code style change part 1 (#106)" This reverts commit 6dae0b3. * Revert "HPAT Build: Code style check for C and Python sources (#103)" This reverts commit 1a30e4f. * Revert "explicitly adding data-file (#104)" This reverts commit 34a2260. * Revert "Remove spark dependency (#102)" This reverts commit 9e77fde. * Wrap functions to be executed twice in runtests.py * Update runtests.py Execute every test specified times, which is set via the REPEAT_TEST_NUMBER environment variable. Skip test_series_list_str_unbox1 because is fails on the second launch with Segmentation fault * Apply comments from review Rename REPEAT_TEST_NUMBER to HPAT_REPEAT_TEST_NUMBER Use os.getenv to get value for HPAT_REPEAT_TEST_NUMBER

* code_style_change_part_2

* Remove spark dependency (IntelPython#102) Remove spark dependency from HPA; use pre-generated sdf_dt.pq * explicitly adding data-file (IntelPython#104) * HPAT Build: Code style check for C and Python sources (IntelPython#103) * HPAT Build: Code style check for C and Python sources * PR103. Comments partially addressed * Code style change part 1 (IntelPython#106) * Style check config fo pystyle (IntelPython#105) * Fix for pandas.merge wrong overload handling of 'on' args (IntelPython#99) Problem description: merge_overload and merge_asof_overload functions use 'on' argument value to compute 'left_on' and 'right_on' arguments in a way that breaks type stability, causing compilation failure when 'on' is assigned a StringLiteral value. Error: File "../hpat/hiframes/dataframe_pass.py", line 202, in _run_assign return self._run_call(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 522, in _run_call return self._run_call_join(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 1488, in _run_call_join left_on = self._get_const_or_list(left_on_var) File "../hpat/hiframes/dataframe_pass.py", line 2135, in _get_const_or_list raise ValueError(err_msg) ValueError: Failed in hpat mode pipeline (step: typed dataframe pass) None Following tests should be fixed with this commit: test_join_cat1 (hpat.tests.test_join.TestJoin) test_join_cat2 (hpat.tests.test_join.TestJoin) test_join_cat_parallel1 (hpat.tests.test_join.TestJoin) test_join_datetime_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq2 (hpat.tests.test_join.TestJoin) test_join_outer_seq1 (hpat.tests.test_join.TestJoin) test_join_right_seq1 (hpat.tests.test_join.TestJoin) test_merge_asof_seq1 (hpat.tests.test_join.TestJoin) * [STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (IntelPython#97) * pep8 style for 'test_strings.py'; flake8 check successful * pep8 style for 'test_utils.py' * pep8 style for 'test_series.py'; more readable * fixed 'test_string_series' * removed extra white spaces * deleted mention of flake8 * trigger build * Code style change part 2 (IntelPython#107) * code_style_change_part_2 * Add more check in style configuration (IntelPython#108) * code_style_part_3 (IntelPython#109) * Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (IntelPython#92) * Code style change part 4 (IntelPython#110) * Revert "Code style change part 4 (IntelPython#110)" This reverts commit dfc54ee. * Revert "Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (IntelPython#92)" This reverts commit 231a76c. * Revert "code_style_part_3 (IntelPython#109)" This reverts commit 4070ce3. * Revert "Add more check in style configuration (IntelPython#108)" This reverts commit abf5bd0. * Revert "Code style change part 2 (IntelPython#107)" This reverts commit 9076493. * Revert "[STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (IntelPython#97)" This reverts commit 8641f7a. * Revert "Fix for pandas.merge wrong overload handling of 'on' args (IntelPython#99)" This reverts commit a2a8ee5. * Revert "Style check config fo pystyle (IntelPython#105)" This reverts commit 551c0e3. * Revert "Code style change part 1 (IntelPython#106)" This reverts commit 6dae0b3. * Revert "HPAT Build: Code style check for C and Python sources (IntelPython#103)" This reverts commit 1a30e4f. * Revert "explicitly adding data-file (IntelPython#104)" This reverts commit 34a2260. * Revert "Remove spark dependency (IntelPython#102)" This reverts commit 9e77fde. * Unskip passing dataframe tests Actually, following tests in test_dataframe.py are pass and can be unskipped: test_create1 test_len1 test_column_getitem1 test_df_apply test_df_apply_branch test_df_describe test_count1 test_append1 At the same time, test_sort_parallel and test_sort_parallel_single_col has some problems with __pycache__: - They are passed if execute the suite with -B - They are passed if execute them separate - They and failed when some tests above are unskipped. So, decide to skip them.

* Remove spark dependency (IntelPython#102) Remove spark dependency from HPA; use pre-generated sdf_dt.pq * explicitly adding data-file (IntelPython#104) * HPAT Build: Code style check for C and Python sources (IntelPython#103) * HPAT Build: Code style check for C and Python sources * PR103. Comments partially addressed * Code style change part 1 (IntelPython#106) * Style check config fo pystyle (IntelPython#105) * Fix for pandas.merge wrong overload handling of 'on' args (IntelPython#99) Problem description: merge_overload and merge_asof_overload functions use 'on' argument value to compute 'left_on' and 'right_on' arguments in a way that breaks type stability, causing compilation failure when 'on' is assigned a StringLiteral value. Error: File "../hpat/hiframes/dataframe_pass.py", line 202, in _run_assign return self._run_call(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 522, in _run_call return self._run_call_join(assign, lhs, rhs) File "../hpat/hiframes/dataframe_pass.py", line 1488, in _run_call_join left_on = self._get_const_or_list(left_on_var) File "../hpat/hiframes/dataframe_pass.py", line 2135, in _get_const_or_list raise ValueError(err_msg) ValueError: Failed in hpat mode pipeline (step: typed dataframe pass) None Following tests should be fixed with this commit: test_join_cat1 (hpat.tests.test_join.TestJoin) test_join_cat2 (hpat.tests.test_join.TestJoin) test_join_cat_parallel1 (hpat.tests.test_join.TestJoin) test_join_datetime_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq1 (hpat.tests.test_join.TestJoin) test_join_left_seq2 (hpat.tests.test_join.TestJoin) test_join_outer_seq1 (hpat.tests.test_join.TestJoin) test_join_right_seq1 (hpat.tests.test_join.TestJoin) test_merge_asof_seq1 (hpat.tests.test_join.TestJoin) * [STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (IntelPython#97) * pep8 style for 'test_strings.py'; flake8 check successful * pep8 style for 'test_utils.py' * pep8 style for 'test_series.py'; more readable * fixed 'test_string_series' * removed extra white spaces * deleted mention of flake8 * trigger build * Code style change part 2 (IntelPython#107) * code_style_change_part_2 * Add more check in style configuration (IntelPython#108) * code_style_part_3 (IntelPython#109) * Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (IntelPython#92) * Code style change part 4 (IntelPython#110) * Cahnge tests execution Actually test suite should be executed via hpat.runtests: python -u -m hpat.runtests -v This resolve the issue with doulbe test suite execution which occurs due to the "python -u -m unittest -v" command import all files in tree including runtests.py and runtests.py triggers 1-st suite execution. Then unittest triggers 2-d. Add decorator to execute some tests (mostly parallel) 2 or more times (depending on existance of REPEAT_TEST_NUMBER environment variable) This should highlight issues like the test fails if executed twice because is corrupts memory during first execution (like test_series_head_index_parallel1) Skip test_series_head_index_parallel1 because it triggers memory corruption. This should be fixed. * Revert "Code style change part 4 (IntelPython#110)" This reverts commit dfc54ee. * Revert "Fix boost runtime issue on Ubuntu16.04 with gcc 5.4 (IntelPython#92)" This reverts commit 231a76c. * Revert "code_style_part_3 (IntelPython#109)" This reverts commit 4070ce3. * Revert "Add more check in style configuration (IntelPython#108)" This reverts commit abf5bd0. * Revert "Code style change part 2 (IntelPython#107)" This reverts commit 9076493. * Revert "[STL] PEP8 code style for 'test_strings.py', 'test_utils.py', 'test_series.py' (IntelPython#97)" This reverts commit 8641f7a. * Revert "Fix for pandas.merge wrong overload handling of 'on' args (IntelPython#99)" This reverts commit a2a8ee5. * Revert "Style check config fo pystyle (IntelPython#105)" This reverts commit 551c0e3. * Revert "Code style change part 1 (IntelPython#106)" This reverts commit 6dae0b3. * Revert "HPAT Build: Code style check for C and Python sources (IntelPython#103)" This reverts commit 1a30e4f. * Revert "explicitly adding data-file (IntelPython#104)" This reverts commit 34a2260. * Revert "Remove spark dependency (IntelPython#102)" This reverts commit 9e77fde. * Wrap functions to be executed twice in runtests.py * Update runtests.py Execute every test specified times, which is set via the REPEAT_TEST_NUMBER environment variable. Skip test_series_list_str_unbox1 because is fails on the second launch with Segmentation fault * Apply comments from review Rename REPEAT_TEST_NUMBER to HPAT_REPEAT_TEST_NUMBER Use os.getenv to get value for HPAT_REPEAT_TEST_NUMBER

code_style_change_part_2

c759d3b

shssf requested a review from fschlimb August 2, 2019 14:36

fschlimb reviewed Aug 2, 2019

View reviewed changes

shssf added 2 commits August 2, 2019 10:57

Revert headers handling. Must be redeveloped in separate PR

7710206

PR107. Brackets with single statement fixed.

c3cd795

shssf and others added 4 commits August 2, 2019 20:20

Merge branch 'master' into code_style_part_2

8d61a40

PR107. revert back python code mess to pass hpat.tests.test_dataframe…

a9b1614

….TestDataFrame.test_sort_parallel test

Revert "PR107. revert back python code mess to pass hpat.tests.test_d…

30f091a

…ataframe.TestDataFrame.test_sort_parallel test" This reverts commit a9b1614.

PR107. revert back python code mess to pass hpat.tests.test_dataframe…

c82eaca

….TestDataFrame.test_sort_parallel test

shssf requested review from Alexander-Makaryev and dmitrii-zagornyi August 3, 2019 20:17

dmitrii-zagornyi reviewed Aug 5, 2019

View reviewed changes

Alexander-Makaryev approved these changes Aug 5, 2019

View reviewed changes

shssf merged commit 9f52798 into master Aug 5, 2019

Vyacheslav-Smirnov pushed a commit to Vyacheslav-Smirnov/sdc that referenced this pull request Aug 7, 2019

Code style change part 2 (IntelPython#107)

9076493

* code_style_change_part_2

Vyacheslav-Smirnov added a commit to Vyacheslav-Smirnov/sdc that referenced this pull request Aug 7, 2019

Revert "Code style change part 2 (IntelPython#107)"

f25454b

This reverts commit 9076493.

Vyacheslav-Smirnov added a commit to Vyacheslav-Smirnov/sdc that referenced this pull request Aug 7, 2019

Revert "Code style change part 2 (IntelPython#107)"

e0f4872

This reverts commit 9076493.

shssf deleted the code_style_part_2 branch August 10, 2019 13:51

kozlov-alexey pushed a commit to kozlov-alexey/sdc that referenced this pull request Oct 4, 2019

Code style change part 2 (IntelPython#107)

440cbae

* code_style_change_part_2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code style change part 2 #107

Code style change part 2 #107

shssf commented Aug 2, 2019

fschlimb left a comment

fschlimb Aug 2, 2019

shssf Aug 2, 2019

fschlimb Aug 2, 2019

fschlimb Aug 2, 2019

shssf Aug 2, 2019

shssf Aug 2, 2019

fschlimb Aug 2, 2019

fschlimb Aug 2, 2019

fschlimb Aug 2, 2019

fschlimb Aug 2, 2019

fschlimb Aug 2, 2019

shssf Aug 2, 2019

fschlimb Aug 2, 2019

shssf Aug 2, 2019

shssf commented Aug 2, 2019

dmitrii-zagornyi Aug 5, 2019

dmitrii-zagornyi Aug 5, 2019

shssf Aug 5, 2019

shssf Aug 5, 2019

Code style change part 2 #107

Code style change part 2 #107

Conversation

shssf commented Aug 2, 2019

fschlimb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shssf commented Aug 2, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment