This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Migrating to Numba 0.51.2 #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: this requires patch for numba to add support of options to intrinsic decorator to be applied first
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-27 05:11:09 UTC |
kozlov-alexey
changed the title
kozlov-alexey
requested review from
PokhodenkoSA,
AlexanderKalistratov and
Hardcode84
Hardcode84
approved these changes
Sep 25, 2020
kozlov-alexey
force-pushed
the
feature/migrate_numba_0.51.2
branch
from
e219515
to
12fc710
Compare
kozlov-alexey
force-pushed
the
feature/migrate_numba_0.51.2
branch
from
b9df499
to
5b6d8b1
Compare
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prefer_literal flag to sdc overload decorators with default value
Trueto satisfy previous Numba behavior.Following problems were solved during transition:
fillnaandastypeoverloads to avoid returning wrong function implementation when compiling with non-literal args first.