This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Fixing issue with named series handling in fillna #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssf
approved these changes
Jul 17, 2019
anmyachev
reviewed
Jul 17, 2019
| @@ -361,7 +361,7 @@ def generic(self, args, kws): | |||
| class FillNaStrType(AbstractTemplate): | |||
| def generic(self, args, kws): | |||
| assert not kws | |||
| assert len(args) == 2 | |||
| assert len(args) == 3 | |||
There was a problem hiding this comment.
It is necessary to correct the comment under this line.
fschlimb
reviewed
Jul 18, 2019
| 'expecting {{i64, i64, i32*, i8*, i8*, i8*}, i8*, ' | ||
| '{i8*, i64, i32, i32, i64, i8*, i8*}} \n' | ||
| 'but got {{i64, i64, i32*, i8*, i8*, i8*}, i8*, i8*}\n') | ||
| def test_series_fillna_inplace1(self): |
There was a problem hiding this comment.
Please add a comment what this function is testing.
There was a problem hiding this comment.
I added some comment (there are no comments for other tests though).
This new test just adds missed check for attempting to jit inplace fillna on series with numeric data. There was a test for string series, but not numeric one.
There was a problem hiding this comment.
That's fine. We want to improve code style and docu. So anything new should be well documented.
kozlov-alexey
force-pushed
the
feature/fix_series_fillna
branch
from
a60740a
to
7ce6277
Compare
[BUG] Fixed problems with generation parquet files (IntelPython#93)
kozlov-alexey
force-pushed
the
feature/fix_series_fillna
branch
from
7ce6277
to
065c970
Compare
fschlimb
approved these changes
Jul 18, 2019
kozlov-alexey
added a commit
to kozlov-alexey/sdc
that referenced
this pull request
Jul 19, 2019
Fixing issue with named series handling in fillna (IntelPython#95)
kozlov-alexey
added a commit
to kozlov-alexey/sdc
that referenced
this pull request
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.