Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial frame notif acc to kpi #10147

Merged

Conversation

remibettan
Copy link
Contributor

Tracked by: DSO-17850

@remibettan remibettan requested a review from ev-mp January 11, 2022 13:24
src/linux/backend-v4l2.cpp Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

std::vector<std::pair<stream_profile, std::deque<long int>>> drops_per_stream;
double _kpi_frames_drops_pct;
};

class v4l_uvc_device : public uvc_device, public v4l_uvc_interface
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with kernel 5+: the 'v4l_uvc_device' class may not apply there

src/linux/backend-v4l2.cpp Outdated Show resolved Hide resolved
src/linux/backend-v4l2.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.cpp Outdated Show resolved Hide resolved
@maloel
Copy link
Collaborator

maloel commented Jun 20, 2022

@remibettan please work with @ev-mp
This PR is needed but the Jira ticket is marked as Implemented for some reason...

@ev-mp ev-mp merged commit a6357eb into IntelRealSense:development Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants