Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retires for USB claim interface + Increase FW update UT stability #10152

Merged
merged 4 commits into from Jan 16, 2022

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jan 13, 2022

Tracked on [LRS-356]

@Nir-Az Nir-Az requested a review from maloel January 13, 2022 07:34
@Nir-Az Nir-Az marked this pull request as draft January 13, 2022 09:12
@Nir-Az Nir-Az force-pushed the fw-update-ut-fail branch 17 times, most recently from 263430e to 19a63ed Compare January 13, 2022 16:20
@Nir-Az Nir-Az marked this pull request as ready for review January 16, 2022 11:53
auto retry_counter = 2;
do
{
LOG_DEBUG( "failed to claim usb interface, interface "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we say we wanted this to be a warning?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to warning

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, you changed line 115?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ fixed

@maloel maloel merged commit 86cbeb6 into IntelRealSense:development Jan 16, 2022
Nir-Az pushed a commit to Nir-Az/librealsense that referenced this pull request Jan 26, 2022
@Nir-Az Nir-Az deleted the fw-update-ut-fail branch May 3, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants