Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash script made an incorrect string comparison #10634

Merged
merged 1 commit into from Sep 15, 2022

Conversation

jcremona
Copy link

if [ "4.4" == PATCHES_REV ];

was replaced with:

if [ "4.4" = "$PATCHES_REV" ];

Missing $.

@dmipx
Copy link
Contributor

dmipx commented Sep 14, 2022

Thanks for contribution!
Please re-submit this PR to 'development' branch so we can merge it.
@Nir-Az can you speedup and change PR branch?

@Nir-Az Nir-Az changed the base branch from master to development September 14, 2022 14:12
@Nir-Az
Copy link
Collaborator

Nir-Az commented Sep 14, 2022

@jcremona Can you confirm testing this change on JP 4.4?

@jcremona
Copy link
Author

@jcremona Can you confirm testing this change on JP 4.4?

I've tested on L4T version 32.2.1. When tested on this version, this script sets PATCHES_REV to 4.4. My Jetson TX2 has a JetPack 4.2.2.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Sep 15, 2022

@jcremona Can you confirm testing this change on JP 4.4?

I've tested on L4T version 32.2.1. When tested on this version, this script sets PATCHES_REV to 4.4. My Jetson TX2 has a JetPack 4.2.2.

Great, thanks!

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit bf48dfd into IntelRealSense:development Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants