Fix two undefined behavior issues (pipeline/config, elpp) #10876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipeline/config: initialize playback_loop We found a UBSan complaint of the value 173 being stored into a boolean in the copy constructor. third-party/easyloggingpp: work around global init order bug The validateFileRolling function is called during the static initialization of an el::Storage, but it tries to access the global el::Storage. Clang compiles this into a branch to ud1. Instead, just skip the function call. PiperOrigin-RevId: 471841322
|
@riking Thanks for your PR, we will look into it. |
|
EasyLogging++ has fixed this too, it seems. I've opened a PR to upgrade to their latest. @riking thanks for the incentive :) I'm going to try to remove the easylogging fix from this PR and then merge it... |
maloel
approved these changes
Sep 7, 2022
|
@riking if the issue persists for you in ELPP, please let us know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline/config: initialize playback_loop
We found a UBSan complaint of the value 173 being stored into a boolean in the copy constructor.
third-party/easyloggingpp: work around global init order bug
The validateFileRolling function is called during the static initialization of an el::Storage, but it tries to access the global el::Storage. Clang compiles this into a branch to ud1. Instead, just skip the function call.
PiperOrigin-RevId: 471841322
The easylogging patch was the quick-and-dirty method to get our binaries to stop crashing. If you have suggestions for a better patch, I'm willing to explore them.