Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GMSL to RS Viewer for D457 #11078

Merged
merged 4 commits into from Nov 17, 2022
Merged

Add GMSL to RS Viewer for D457 #11078

merged 4 commits into from Nov 17, 2022

Conversation

noacoohen
Copy link
Contributor

@noacoohen noacoohen commented Nov 8, 2022 •
edited

Add GMSL to RS Viewer for D457
Tracked on LRS-533

updated according to last commit:

white

@Nir-Az
Copy link
Collaborator

Nir-Az commented Nov 8, 2022 •
edited

  1. Please add the relevant ticket number "Tracked on [LRS-XXX]
  2. Please add a screenshot of the output here or in the ticket
  3. Once you open a PR, you need to add a "Reviewer" on Github, default is me.

Nir-Az
Nir-Az reviewed Nov 8, 2022
View reviewed changes
common/model-views.cpp Outdated Show resolved Hide resolved
Nir-Az
Nir-Az reviewed Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit db41823 into IntelRealSense:D4XX_MIPI Nov 17, 2022
@noacoohen noacoohen deleted the GMSL branch November 22, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noacoohen @Nir-Az @remibettan