Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build_CI restructure with live-tests on Linux only #11165

Merged
merged 3 commits into from Dec 4, 2022

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Dec 3, 2022

This solves the problem with recent change on the DDS branch: the server image of Windows-2019 has changed and the Windows_testing_cpp_USB_Win7 job no longer passes for an unknown reason.

The CI rework achieves better runtime on average:

  • Moves live-tests to be all on the Linux side until the Windows build has no issues in it
  • No more BUILD_WITH_TM2 builds
  • Job names reflect what they actually run
  • DDS on Ubuntu 20

CMake/external_fastdds.cmake Outdated Show resolved Hide resolved
@maloel maloel changed the title FastDDS 2.8.1; CI restructure Build_CI restructure with live-tests on Linux only Dec 4, 2022
@maloel
Copy link
Collaborator Author

maloel commented Dec 4, 2022

Removed the 2.8.1 changes; changed the title and commit message.

@@ -265,7 +195,7 @@ jobs:
- name: Upload RS log artifact
uses: actions/upload-artifact@v2
with:
name: Log file - Linux_testing_cpp
name: Log file - U20_SH_Py_LiveTest_DDS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why DDS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover. Fixed...

@Nir-Az Nir-Az self-requested a review December 4, 2022 18:03
@maloel maloel merged commit 1dd3608 into IntelRealSense:dds Dec 4, 2022
maloel added a commit to maloel/librealsense that referenced this pull request Dec 6, 2022
…ts on Linux only

(cherry picked from commit 1dd3608)

# Conflicts:
#	.github/workflows/buildsCI.yaml
@maloel maloel deleted the dds281 branch January 24, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants