New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build_CI restructure with live-tests on Linux only #11165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Dec 4, 2022
(cherry picked from commit 4fdab16)
maloel
changed the title
FastDDS 2.8.1; CI restructure
Build_CI restructure with live-tests on Linux only
Dec 4, 2022
Removed the 2.8.1 changes; changed the title and commit message. |
Nir-Az
reviewed
Dec 4, 2022
.github/workflows/buildsCI.yaml
Outdated
@@ -265,7 +195,7 @@ jobs: | |||
- name: Upload RS log artifact | |||
uses: actions/upload-artifact@v2 | |||
with: | |||
name: Log file - Linux_testing_cpp | |||
name: Log file - U20_SH_Py_LiveTest_DDS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why DDS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover. Fixed...
Nir-Az
reviewed
Dec 4, 2022
Nir-Az
reviewed
Dec 4, 2022
Nir-Az
approved these changes
Dec 4, 2022
maloel
added a commit
to maloel/librealsense
that referenced
this pull request
Dec 6, 2022
…ts on Linux only (cherry picked from commit 1dd3608) # Conflicts: # .github/workflows/buildsCI.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem with recent change on the DDS branch: the server image of Windows-2019 has changed and the
Windows_testing_cpp_USB_Win7
job no longer passes for an unknown reason.The CI rework achieves better runtime on average:
BUILD_WITH_TM2
builds