stabilized-value in pyrsutils; replace 9 cpp tests with 1 py #11214
Conversation
| auto not_empty = []( stabilized_value const & self ) { | ||
| return ! self.empty(); | ||
| }; | ||
| auto to_string = []( stabilized_value const & self ) -> std::string { |
There was a problem hiding this comment.
those 2 functions are global will generic names but have a specific implementation.
What will happen the next time you want to add them to a different utility?
Can you use some namespace or rename to a more specific var names?
There was a problem hiding this comment.
Global? No, they're just in this code.
If needed, we'll rename or move inline.
There was a problem hiding this comment.
I meant that it's not binds to the stabilized value utility, it is known in all of pyrsutils
| test.finish() | ||
| # | ||
| ############################################################################################# | ||
| test.print_results_and_exit() |
There was a problem hiding this comment.
IMO 2 tests are missing:
TEST_CASE("update stable value - last stable not in history", "[stabilized value]")
TEST_CASE("update stable value - last stable is in history", "[stabilized value]")
There was a problem hiding this comment.
I didn't see them in the cpp files... you see them?
There was a problem hiding this comment.
Oh I think ,aybe you're right, I'll add
Only one test is left -- the multithreaded one.