Update GHA linux runners to Ubuntu 20 #11627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
force-pushed
the
update_gha_ubuntu
branch
from
a26a837
to
dd9b161
Compare
Nir-Az
force-pushed
the
update_gha_ubuntu
branch
5 times, most recently
from
0ad4e57
to
4d8d1df
Compare
Nir-Az
force-pushed
the
update_gha_ubuntu
branch
from
4d8d1df
to
0de62a5
Compare
|
@OhadMeir ready for review. |
Nir-Az
commented
Mar 29, 2023
| sudo apt-get install libglfw3-dev libglfw3; | ||
| sudo apt-get install gcc-7 g++-7; |
There was a problem hiding this comment.
TODO Add comment on all places we force the GCC version with the reason
OhadMeir
reviewed
Mar 29, 2023
| @@ -258,8 +258,8 @@ jobs: | |||
|
|
|||
|
|
|||
| #-------------------------------------------------------------------------------- | |||
| U18_SH_RSUSB_LiveTest: # Ubuntu 2018, Shared, Legacy live-tests | |||
| runs-on: ubuntu-18.04 | |||
| U20_SH_RSUSB_LiveTest: # Ubuntu 2020, Shared, Legacy live-tests | |||
There was a problem hiding this comment.
Log file names should be updated. See example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA deprecate Ubuntu 18 runners,
We update the CI to use Ubuntu 20 runners
See https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/
When I used the default compiler (GCC 9.5) it used lto (link time optimization) and it failed on an internal error.
So I forced it to use GCC 7 which compile.