Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata test alive calibration #11653

Merged

Conversation

Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented Apr 4, 2023

The test was improved by adding waiting time.
No ticket was opened for it.

@Tamir91 Tamir91 requested a review from Nir-Az April 4, 2023 14:25
@@ -104,5 +105,6 @@ def is_value_keep_increasing(metadata_value, number_frames_to_test=50) -> bool:
test.finish()

close_resources(sensor)
time.sleep(0.3)
Copy link
Collaborator

@Nir-Az Nir-Az Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment
# better sleep before stop/start streaming so we can let the device recover properly

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 7f196bc into IntelRealSense:development Apr 5, 2023
15 of 16 checks passed
@Tamir91 Tamir91 added the python label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants