Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow change AE type while not streaming (even if AE is on) #11699

Merged
merged 2 commits into from Apr 19, 2023
Merged

Allow change AE type while not streaming (even if AE is on) #11699

merged 2 commits into from Apr 19, 2023

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Apr 18, 2023

Tracked on [DSO-18943]

@Nir-Az Nir-Az requested a review from maloel April 18, 2023 16:51
@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Apr 18, 2023 •
edited

@maloel UT change is coming.. I want to see it's failing first.

Update # 1:
It will not fail as it only runs on FW >= 5.15...
I will run the test locally and update it
Update # 2:
Done
Log before test update:

Verify cannot set when auto exposure on
-E- Traceback (most recent call last):
  File "C:\Work\Git\librealsense\unit-tests\live/d400/test-depth_ae_mode.py", line 33, in <module>
    test.check_equal(depth_sensor.get_option(rs.option.auto_exposure_mode), REGULAR)
    left  : 1.0
    right : 0.0
Test failed

maloel
maloel reviewed Apr 19, 2023
View reviewed changes
src/ds/d400/d400-device.cpp
depth_sensor.register_option(
RS2_OPTION_DEPTH_AUTO_EXPOSURE_MODE,
std::make_shared< gated_option >( depth_auto_exposure_mode, options_and_reasons ) );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the gating be dependent on the FW version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gated was removed as discussed

@Nir-Az Nir-Az merged commit e9a3095 into IntelRealSense:development Apr 19, 2023
16 checks passed
Nir-Az added a commit to Nir-Az/librealsense that referenced this pull request Apr 19, 2023
@Nir-Az
PR IntelRealSense#11699 from Nir-Az: Allow change AE type while not s…
8115d60 
…treaming (even if AE is on)

(cherry picked from commit e9a3095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nir-Az @maloel