Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Linux installation guide. #11713

Merged
merged 13 commits into from Jun 19, 2023
Merged

Refactoring Linux installation guide. #11713

merged 13 commits into from Jun 19, 2023

Conversation

Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented Apr 20, 2023 •
edited

Tracked on [LRS-734]

In this PR we started refactoring our manual installation Linux guide.

OLD NEW
The next changes performed:

  1. All instructions regarding Ubuntu 14/16, TM1 were removed.
  2. Commands were separated into categories.

@Tamir91 Tamir91 requested review from ev-mp and Nir-Az April 20, 2023 11:22
@Nir-Az Nir-Az requested a review from remibettan April 20, 2023 11:28
@Nir-Az
Copy link
Collaborator

Nir-Az commented Apr 20, 2023

I am not sure it's good to rename the installation.ms, we might have Intel website pointing to it.

@ev-mp what do you think?

@Nir-Az
Copy link
Collaborator

Nir-Az commented Apr 20, 2023

I am not sure it's good to rename the installation.ms, we might have Intel website pointing to it.

@ev-mp what do you think?

Looks like we have a copy of all here
@ev-mp do you know how we can have access to edit this?

@Tamir91
Copy link
Contributor Author

Tamir91 commented Apr 21, 2023 •
edited by Nir-Az

I am not sure it's good to rename the installation.ms, we might have Intel website pointing to it.
@ev-mp what do you think?

Looks like we have a copy of all here @ev-mp do you know how we can have access to edit this?

I see the suggest edits button on the page, but looks like need Login/Sign Up before...

I am an Admin there so I can edit it, but if we change it we will need to verify we doin miss pointers to in, inside our repo and on the public website as well.

@Tamir91 Tamir91 requested a review from Nir-Az May 31, 2023 13:11
@Tamir91 Tamir91 requested a review from Nir-Az May 31, 2023 14:22
Nir-Az
Nir-Az reviewed Jun 1, 2023
View reviewed changes
doc/installation_linux_manual.md Outdated
* Ubuntu 18/20 with LTS kernel (< 5.13) \
`./scripts/patch-realsense-ubuntu-lts.sh`

**Note:** What the *.sh script perform?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the *.sh script perform? , just start with The script above will...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jun 1, 2023

Please Carefully merge with the updated installation.md
image

@Tamir91
Copy link
Contributor Author

Tamir91 commented Jun 15, 2023

After all I will rename file to his old name.

@Tamir91 Tamir91 requested a review from Nir-Az June 19, 2023 09:45
@Nir-Az Nir-Az self-requested a review June 19, 2023 11:09
@Nir-Az Nir-Az merged commit 79f76b8 into IntelRealSense:development Jun 19, 2023
15 of 16 checks passed
@Tamir91
Copy link
Contributor Author

Tamir91 commented Jul 2, 2023 •
edited

We want create similar page to our other repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

@ev-mp ev-mp Awaiting requested review from ev-mp

@remibettan remibettan Awaiting requested review from remibettan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tamir91 @Nir-Az