log_to_console now logs to console in Windows #11834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
May 24, 2023
common/ux-window.cpp
Outdated
| @@ -63,7 +63,14 @@ namespace rs2 | |||
| config_file::instance().set_default(configurations::window::saved_size, false); | |||
|
|
|||
| config_file::instance().set_default(configurations::viewer::is_measuring, false); | |||
| config_file::instance().set_default(configurations::viewer::log_to_console, true); | |||
| config_file::instance().set_default(configurations::viewer::log_to_console, | |||
| #ifdef WIN32 | |||
There was a problem hiding this comment.
This looks like bad alignment.
I suggest
auto default_log_to_console = true;
// In Windows, there is no console by default
#ifdef WIN32
default_log_to_console = false;
#endif
config_file::instance().set_default(configurations::viewer::log_to_console, default_log_to_console );
Nir-Az
reviewed
May 24, 2023
src/log.h
Outdated
| @@ -180,6 +181,8 @@ namespace librealsense | |||
|
|
|||
| void log_to_console(rs2_log_severity min_severity) | |||
| { | |||
| if( min_severity != RS2_LOG_SEVERITY_NONE ) | |||
| rsutils::os::ensure_console(); | |||
There was a problem hiding this comment.
Did you test how python on Windows behave with this code?
There was a problem hiding this comment.
Everything behaves the same -- python is usually started from a console.
Only thing new is that, if there is no console, a new window will pop up (on Windows).
There was a problem hiding this comment.
One thing we could do is create a console if the build is a debug build, with the idea being that, when debugging, you do want to see the debug in a separate window...
There was a problem hiding this comment.
I think the current implementation is better.
Let's not surprise the users.
Nir-Az
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The viewer has a setting:
The default is to log to console, minimum level Warning.
This did nothing in Windows. It does not affect the Debug Console Window in the Viewer.
This changes:
rsutilsfunction toensure_console()which we now use when callinglog_to_consoleNOTE that I had to make this work in both Shared and Static builds. In the former, anything outside of librealsense will not affect the librealsense logs - so I had to place the console-opening inside librealsense (originally it was only in the Viewer).