Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Use plain add_library #12003

Merged
merged 1 commit into from Aug 6, 2023

Conversation

autoantwort
Copy link

Does the same with less code.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jul 17, 2023

@autoantwort Thanks for the PR.

I have got 2 requested.

  1. Can you please base the PR and target it to development branch (like mentioned here)
  2. I was missing some explanation about why is it the same, I found it in CMake documentation
If no type is given explicitly the type is STATIC or SHARED based on whether the current value of the variable [BUILD_SHARED_LIBS](https://cmake.org/cmake/help/v3.10/variable/BUILD_SHARED_LIBS.html#variable:BUILD_SHARED_LIBS) is ON

Can you please add this as a comment above the new line?

@autoantwort autoantwort changed the base branch from master to development August 6, 2023 09:40
@autoantwort
Copy link
Author

Done :)

@Nir-Az Nir-Az self-requested a review August 6, 2023 18:20
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Less is more"
CI failures doesn't look related.
Thanks for the PR

@Nir-Az Nir-Az merged commit 3a04020 into IntelRealSense:development Aug 6, 2023
13 of 16 checks passed
@autoantwort autoantwort deleted the less-code-2 branch August 6, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants