Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor device.h #12200

Merged
merged 12 commits into from Sep 26, 2023
Merged

Refactor device.h #12200

merged 12 commits into from Sep 26, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Sep 16, 2023

Removed some unused functions, took stuff out of types.h, etc.
Only last two commits have minor functional changes:

  • PID was a public member of device - moved to ds_device (not used in non-uvc devices, like software devices)
  • simplified stream_profile and added comments

Sensor.h is next...

Tracked on [LRS-881]

Copy link
Contributor

@SamerKhshiboun SamerKhshiboun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any reason why libci failed ?

@maloel
Copy link
Collaborator Author

maloel commented Sep 26, 2023

Any reason why libci failed ?

Not related. I just reran it:
https://rsjenkins.iil.intel.com/job/LRS_libci_pipeline/6104/

All passed.

@maloel maloel merged commit 640d281 into IntelRealSense:development Sep 26, 2023
15 of 16 checks passed
@maloel maloel deleted the device-h branch September 26, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants