New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actual FPS simplification & unit change [API change] #12326
Conversation
# Conflicts: # src/sync.cpp # src/sync.h # unit-tests/syncer/sw.py
Can we run a "Semi" RealCI and see jo reggression. |
No |
Two Semi runs of RealCI came back clean so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We see no regressions on external sync slave setups (which prompted this change):
|
RealCI on the D457 ran twice; no new behavior observed. |
RS2_FRAME_METADATA_ACTUAL_FPS
is now really the actual FPS, same as shown in the viewer asHardware FPS
, although with better precision:d400_device
derivatives; actual FPS will now be correctframe_interface::find_metadata()
to both check and get metadata - should save on performance, especially relevant in the syncerRelated to [RSDSO-19336]