Add feature-interface to sensors #12384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
maloel
reviewed
Nov 9, 2023
OhadMeir
force-pushed
the
development
branch
from
03b6ffa
to
9880893
Compare
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
|
|
||
| namespace librealsense { | ||
|
|
||
| class synthetic_sensor; |
There was a problem hiding this comment.
If it requires roi_sensor_interface, why not put that right in the interface?
maloel
reviewed
Nov 19, 2023
maloel
reviewed
Nov 19, 2023
…rface with simplified API
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
src/core/features-container.h
Outdated
|
|
||
| void register_feature( const std::string id, std::shared_ptr< feature_interface > feature ) | ||
| { | ||
| _features[id] = feature; |
There was a problem hiding this comment.
It'll override any previous value... ok?
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
reviewed
Nov 26, 2023
maloel
approved these changes
Nov 26, 2023
… get_supported_features
OhadMeir
force-pushed
the
development
branch
from
4b6bb86
to
25fbb9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
support_featureAPI to sensors.Features derive from
feature_interfaceand concrete sensor determines support for individual features.Features can act as a flag to other logic about need to act in a certain way, or even have the logic implementation embodied.