third test on image quality removed. now using max laser power #12386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Nov 9, 2023
| @@ -84,6 +84,8 @@ def get_frames(config, laser_enabled): | |||
| pipeline_profile = pipeline.start(config) | |||
|
|
|||
| sensor = pipeline_profile.get_device().first_depth_sensor() | |||
| if sensor.supports(rs.option.laser_power) and laser_enabled: | |||
There was a problem hiding this comment.
- Do you think setting it to max will help D400 devices to always pass?
- Please consider switching conditions to save performance entering the function when not needed.
if laser_enabled && sensor.supports(rs.option.laser_power) :
There was a problem hiding this comment.
1 - I don't think so. I tried running max laser power vs default laser power, and sometimes the default had less black pixels than the max (we'd expect it to have more)
2 - will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-902]