fix PR #12378 missing recordable< recommended-pbs > #12420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12378 removed the
recommended_processing_blocks_base
derivation but I forgot to add back therecordable< recommended_processing_blocks_interface >
derivation.This was not caught anywhere, isn't tested, and cannot be caught by compilation since the dependency is only using a
dynamic_cast
which then failed. The result was that the recommended processing blocks were not recorded, so playback didn't have them.I tried adding a test using a software-device but got stuck because there's no public API to add recommended processing blocks to a sensor... I manually tested and made sure it now happens.
Tracked on [LRS-954]