Don't get GVD a second time to check if camera is locked #12528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Dec 19, 2023
| @@ -121,6 +121,12 @@ namespace librealsense | |||
| return _is_locked; | |||
| } | |||
|
|
|||
| bool ds_device_common::is_locked( const uint8_t * gvd_buff, uint32_t offset ) | |||
There was a problem hiding this comment.
Let delete the other function
There was a problem hiding this comment.
Deleted unused functions
Nir-Az
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make minimum changes I added an overload to
ds_device_common::is_lockedthat gets the previously queried buffer, avoiding the need to get the GVD buffer again.