Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to unstable unit test - rgb options metadata consistency #12549

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Dec 31, 2023

Tracked on [LRS-992]

Add more debug information on test log

@Nir-Az Nir-Az marked this pull request as draft December 31, 2023 10:21
@Nir-Az Nir-Az force-pushed the fix-rgb-options-metadata-consistency-test branch 2 times, most recently from 3cf90ca to 49fdd18 Compare December 31, 2023 12:00
@Nir-Az Nir-Az requested a review from OhadMeir December 31, 2023 13:49
@Nir-Az Nir-Az changed the title Stabilize rgb options metadata consistency test Add logs to unstable unit test - rgb options metadata consistency Dec 31, 2023
@Nir-Az Nir-Az marked this pull request as ready for review December 31, 2023 13:50
color_sensor.set_option(rs.option.enable_auto_white_balance, 0)
log.d("enable_auto_white_balance new value we read back is:", color_sensor.get_option(rs.option.enable_auto_white_balance))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we are not waiting. Are you expecting an updated value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will add a check for that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Nir-Az Nir-Az force-pushed the fix-rgb-options-metadata-consistency-test branch from 49fdd18 to 644ba24 Compare January 1, 2024 10:58
@@ -4,7 +4,8 @@
#test:device each(D400*)

import pyrealsense2 as rs
from rspy import test
from rspy import test, log
import time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 5272faa into IntelRealSense:development Jan 1, 2024
15 of 17 checks passed
@Nir-Az Nir-Az deleted the fix-rgb-options-metadata-consistency-test branch January 9, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants