Pose stream info #3010
Merged
Pose stream info #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abernste
commented
Jan 6, 2019
abernste
commented
- Add pose info of: Velocity, Angular Velocity, Acceleration, Angular Acceleration, Translation, Rotation - to pose max screen
- Pose info color changes according to pose confidence: High confidence - Green, Medium confidence - Yellow, Low confidence - Red, failed confidence - Grey
- Fix many warnings
Merge from librealsense/Development
Merge from librealsense/Development
…r Acceleration, Translation, Rotation - to pose max screen 2. Pose info color changes according to pose confidence: High confidence - Green, Medium confidence - Yellow, Low confidence - Red, failed confidence - Grey 2. Fix many warnings
ev-mp
requested changes
Jan 7, 2019
common/model-views.cpp
Outdated
| break; | ||
| case 0: // failed confidence - Grey | ||
| ImGui::PushStyleColor(ImGuiCol_Text, grey); | ||
| break; |
There was a problem hiding this comment.
Add Default to avoid potential issues
common/model-views.cpp
Outdated
| } | ||
| case RS2_STREAM_POSE: | ||
| { | ||
| if ((*this).fullscreen == true) |
There was a problem hiding this comment.
Is there an alternative display when in a non-fullscreen mode?
| std::string data = "["; | ||
| std::string comma = ""; | ||
| unsigned int i = 0; | ||
| while ((pose.data[i] != FLT_MAX) && (i<4)) |
There was a problem hiding this comment.
Is the extra-verbosity by design ? If so - please put comments.
ev-mp
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.