Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Major (Breaking) Change⚠️
Added
Is(Extension)
andAs<T>
for castingThis means that the following are no longer supported and evaluate to true:
You should either explicitly cast the results:
Or better yet, look for a generic version, these are usually more optimized:
There are several reasons for doing this:
Added motion and pose support (D435i, T265 & software device)
Added frame metadata support
Took pools out of individual types and added
ObjectPool
Added math types to
Intel.RealSense.Math
Points.CopyTo(Vertex[] array)
changed toPoints.CopyVertices<T>(T[] vertices)
for better support of external types likeUnityEngine.Vector3
,System.Numerics.Vector3
(SIMD) or plain oldfloat[]
. Same for texture coordinates.Removed
IEnumerable<Frame>
fromPipeline
andFrameQueue
Implementation was wrong and it didn't make much sense anyway...
What we really want is probably
IAsyncEnumerable
\AsyncEnumerator
\System.Reactive
extensions.Runtime platform detection for
memcpy
on Linux \ Android (MacOS untesed)Continued refactoring classes and folders