Android error handling fix #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matkatz
commented
May 21, 2019
matkatz
commented
- reset the streaming endpoint in case of overflow.
- fix wrong error handling on android usb transfer commands
- release device/sensor instances that kept alive in the camera app
ev-mp
reviewed
May 21, 2019
| messenger->reset_endpoint(read_ep, reset_ep_timeout); | ||
| break; | ||
| case librealsense::platform::RS2_USB_STATUS_SUCCESS: | ||
| strctx->stream->got_bytes = transferred; |
There was a problem hiding this comment.
this is the name in all of our UVC implementations, we can change it when moving to rsuvc
There was a problem hiding this comment.
I am using libuvc under Android, how can I handle the error?
src/android/usb_host/android_uvc.cpp
Outdated
| @@ -938,19 +938,27 @@ void stream_thread(usbhost_uvc_stream_context *strctx) { | |||
| } | |||
| }); | |||
| LOG_DEBUG("Transfer thread started for endpoint address: " << strctx->endpoint); | |||
| bool disconnect = false; | |||
| do { | |||
| auto i = strctx->stream->stream_if->interface; | |||
| uint32_t transferred = 0; | |||
| auto sts = messenger->bulk_transfer(read_ep, strctx->stream->outbuf, LIBUVC_XFER_BUF_SIZE, transferred, 1000); | |||
There was a problem hiding this comment.
Why do you use hard-coded timeouts ? (1000, 50)
There was a problem hiding this comment.
will create a define, it is not accessible to the app level
ev-mp
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.