Firmware Update integration with the Viewer #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Jun 25, 2019
| @@ -152,9 +154,61 @@ Some auxillary functionalities might be affected. Please report this message if | |||
| return (int)(floor(scale)); | |||
| } | |||
|
|
|||
| const char* file_dialog_open(file_dialog_mode flags, const char* filters, const char* default_path, const char* default_name) | |||
| bool directory_exists(const char* dir) | |||
include/librealsense2/h/rs_device.h
Outdated
| const rs2_raw_data_buffer* rs2_create_flash_backup(const rs2_device* device, rs2_update_progress_callback_ptr callback, void* client_data, rs2_error** error); | ||
|
|
||
| /** | ||
| * Enter the device to update state, this will cause the updatable device to disconnect and reconnect as update device. |
There was a problem hiding this comment.
Mention that the device must support RS2_EXTENSION_UPDATABLE extension
include/librealsense2/h/rs_device.h
Outdated
| @@ -146,6 +146,55 @@ void rs2_connect_tm2_controller(const rs2_device* device, const unsigned char* m | |||
| */ | |||
| void rs2_disconnect_tm2_controller(const rs2_device* device, int id, rs2_error** error); | |||
|
|
|||
| /** | |||
| * Update device to the provided firmware, the device must be extendable to RS2_EXTENSION_UPDATABLE. | |||
| * This call is executed on the caller's thread and it supports progress notifications via the optional callback. | |||
There was a problem hiding this comment.
Note that this shall be called when the device has already been switched into RS2_EXTENSION_UPDATE_DEVICE
ev-mp
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes #4267 as a prerequisite.
Adds streamlined integration of firmware update process directly into the Viewer:
Thanks to #4267 this should be available on all supported platforms and architectures, eliminating limitations of current firmware update tool.
This PR is still being tested so pull on your own risk.