Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syncer support for sensor start method #4546

Merged
merged 1 commit into from Aug 4, 2019
Merged

Add syncer support for sensor start method #4546

merged 1 commit into from Aug 4, 2019

Conversation

arilowen
Copy link
Contributor

@arilowen arilowen commented Aug 1, 2019 •
edited by ev-mp

DSO-13062

  • Now a sensor can call start with a syncer instance as a parameter (Python).

@dorodnic
Copy link
Contributor

dorodnic commented Aug 4, 2019

Tested?

@dorodnic dorodnic merged commit fdcfd34 into IntelRealSense:development Aug 4, 2019
@lramati
Copy link
Contributor

lramati commented Aug 13, 2019

Is it really OK to take syncer by value and not by reference? Additionally, it would be nice to have the argument name exposed as "syncer" in the Python help.

@arilowen arilowen deleted the add-sensor-syncer branch December 3, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorodnic dorodnic dorodnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arilowen @dorodnic @lramati @alowenst01