rs-multicam bug fix #4596
Merged
rs-multicam bug fix #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulting in new unique-id for each new frame, causing allocation of new textures and memory leak)
dorodnic
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rs-multicam example bug (memory leak):
Previously the same colorizer was used for all devices, as a result a new unique-id was assigned for each received frame. Since textures are stored by the frame's unique id in example.hpp (in function
render_video_frame), the change of ids caused allocation of a new texture for each frame, resulting in a memory leak.Fix: store a map from device serial number to
rs::colorizerand use a separate colorizer for each device.