Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed errors caused by dynamic variable cast #5922

Merged
merged 2 commits into from Mar 11, 2020
Merged

Fixed errors caused by dynamic variable cast #5922

merged 2 commits into from Mar 11, 2020

Conversation

nullptr-deref
Copy link
Contributor

During compilation, Make complained that in initializer list cannot be any
implicitly casted values so I've fixed this issue.

@nullptr-deref
Fixed errors caused by dynamic variable cast
e6c34f9 
During compilation, Make complained that in initializer list cannot be any
implicitly casted values so I've fixed this issue.
ev-mp
ev-mp approved these changes Mar 1, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@militaryCoder , thank you for the contribution,
I'll redirect the PR to development stream as this the policy we practice.

@ev-mp ev-mp changed the base branch from master to development March 1, 2020 10:19
ev-mp
ev-mp reviewed Mar 1, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@militaryCoder , can you rebase to development branch and check whether the PR is still needed ?
Apparently a similar fix has already been accepted (thus the merge conflict).
Thank you

@nullptr-deref
Copy link
Contributor Author

I see what you mean.
I cloned development branch and tried to build it and it succeeded.
I think I'll continue watching this problem until next release.

@dorodnic dorodnic merged commit 62e087b into IntelRealSense:development Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

@dorodnic dorodnic dorodnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nullptr-deref @dorodnic @ev-mp