Disable creation of unnecessary log files #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI build: github.com/AndrejOrsula/librealsense/runs/626951088 (passed) |
|
Hi @AndrejOrsula |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS: Ubuntu 18.04
SDK: 2.34.0
Device: D415
Issue Description: I am experiencing a purely cosmetic issue, where calls to
log_to_console()create log files, i.e.yyyy-MM-dd-HH_mm_ss.log, that remain empty because no logging to file withlog_to_file()was requested. I suspectlog_to_callback()to result in a similar behaviour as it also callsopen()internally, but I have not tested my hypothesis. I assume that this behaviour is unintentional.Suggested Solution: Configure filename for logging ONLY if it was requested, in which case
minimum_file_severityis different thanRS2_LOG_SEVERITY_NONE.