New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to override the official SW update server url #6593
Add capability to override the official SW update server url #6593
Conversation
Nir-Az
commented
Jun 15, 2020
f14f7e5
to
3ec2879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple formatting changes that are not essential in viewer.cpp - and some of them "break" the previous alignment like in lines 1463-1467.
can you drop those and leave only the new code?
common/model-views.h
Outdated
@@ -161,6 +163,8 @@ namespace rs2 | |||
static const char* allow_rc_firmware { "update.allow_rc_firmware" }; | |||
static const char* recommend_updates { "update.recommend_updates" }; | |||
static const char* recommend_calibration { "update.recommend_calibration" }; | |||
static const char* sw_updates_url { "update.sw_update_url" }; | |||
static const char* sw_updates_operational_server { "update.sw_update_oprational_server" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oprational public/official
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to official
common/model-views.h
Outdated
@@ -161,6 +163,8 @@ namespace rs2 | |||
static const char* allow_rc_firmware { "update.allow_rc_firmware" }; | |||
static const char* recommend_updates { "update.recommend_updates" }; | |||
static const char* recommend_calibration { "update.recommend_calibration" }; | |||
static const char* sw_updates_url { "update.sw_update_url" }; | |||
static const char* sw_updates_operational_server { "update.sw_update_oprational_server" }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operational public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to official
3ec2879
to
1ca7930
Compare
1ca7930
to
bc9c472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM