Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexify helper method name in test changed to char2hex #6629

Merged
merged 1 commit into from Jun 18, 2020
Merged

hexify helper method name in test changed to char2hex #6629

merged 1 commit into from Jun 18, 2020

Conversation

remibettan
Copy link
Contributor

Same name of helper function in global namespace lead to failure in linkage.

ev-mp
ev-mp requested changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why C&P instead or reuse the original function? Disregard this

ev-mp
ev-mp approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now types.h. will remain private.

@ev-mp ev-mp merged commit d6b9c65 into IntelRealSense:development Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remibettan @ev-mp