waitForFrames timeout - all calls changed to default - 5s #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Jun 25, 2020
| @@ -24,7 +24,7 @@ public void stop() { | |||
| } | |||
|
|
|||
| public FrameSet waitForFrames() throws Exception { | |||
| return waitForFrames(5000); | |||
| return waitForFrames(5000); //defining default timeout | |||
There was a problem hiding this comment.
So you can drop the value since it's the default.
There was a problem hiding this comment.
Well this is the place in which the default is assigned.
There is no API method without the timeout, so it should be assigned before calling the API method.
ev-mp
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all calls to waitForFrames timeouts changed to default - 5 sec