Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe unit test for first frame delay issue #8214

Merged
merged 15 commits into from Feb 1, 2021
Merged

Pipe unit test for first frame delay issue #8214

merged 15 commits into from Feb 1, 2021

Conversation

nohayassin
Copy link
Contributor

@nohayassin nohayassin commented Jan 21, 2021 •
edited

unit test for time to first frame delay issue
Tested on D435i and L515, USB3
Track on DSO-16305

ev-mp
ev-mp requested changes Jan 23, 2021
View reviewed changes
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
ev-mp
ev-mp requested changes Jan 25, 2021
View reviewed changes
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
ev-mp
ev-mp reviewed Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

unit-tests/internal/internal-tests-extrinsic.cpp Outdated Show resolved Hide resolved
ev-mp
ev-mp requested changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the comments.
Also make a squashed PR with 2-3 commits.

ev-mp
ev-mp approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, approved

@ev-mp ev-mp merged commit 9044b61 into IntelRealSense:development Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nohayassin @ev-mp